Method join #2651
Method join #2651
Conversation
src/arrayMethodJoin.js
Outdated
| @@ -5,7 +5,34 @@ | |||
| */ | |||
| function applyCustomJoin() { | |||
| [].__proto__.join2 = function(separator) { | |||
| // write code here | |||
| let separatorValue = separator; | |||
There was a problem hiding this comment.
You may use the separator parameter and get rid of this declaration along with if, if you add a default value in the parameter declaration
[].__proto__.join2 = function(separator = ',') {
src/arrayMethodJoin.js
Outdated
| separatorValue = ','; | ||
| } | ||
|
|
||
| const arr = this; |
There was a problem hiding this comment.
I'd say arr variable is unnecessary, from the context of this implementation it's implied this refers to an array
src/arrayMethodJoin.js
Outdated
| return ''; | ||
| } | ||
|
|
||
| for (const element of arr) { |
There was a problem hiding this comment.
If you need an index regular for loop with let i = 0; i < this.length; i++ would be better
src/arrayMethodJoin.js
Outdated
|
|
||
| for (const element of arr) { | ||
| const str = element === null | ||
| || element === undefined ? '' : element.toString(); |
There was a problem hiding this comment.
element.toString(); -> regarding this part, I personally am not sure whether all data types have .toString method, it would be safer to user something like String(element) or interpolate ${element}
result += this[i] === null || this[i] === undefined ? '' : String(this[i])
src/arrayMethodJoin.js
Outdated
|
|
||
| result += str; | ||
|
|
||
| if (arr.indexOf(element) < arr.length - 1) { |
There was a problem hiding this comment.
If you go with the previously suggested changes this here could be shortened to:
if (i < this.length - 1) {
result += String(separator)
}
|
I refactor this code like you said and yea is shorter and more readable :D |
src/arrayMethodJoin.js
Outdated
| result += this[i] === null || this[i] === undefined | ||
| ? '' : String(this[i]); |
There was a problem hiding this comment.
In my opinion this would be even more readable:
if (this[i] !== undefined && this[i] !== null) {
result += String(this[i]);
}
Soultion to tests